Multi Faceted Review

Multi-dimensional review gate — scope, standards, and risk

Checks

Check	Description	Type	Blocking
scope_prd_match	PRD exists (scope validation is performed by code-reviewer agent)	File exists	Yes
scope_acceptance_criteria	All acceptance criteria from stories are addressed	Custom	Yes
scope_no_creep	No undocumented features added beyond spec	File exists	No
standards_conventions	Code follows project conventions	File exists	No
risk_security	No OWASP Top 10 vulnerabilities detected	Custom	Yes
risk_performance	No obvious performance regressions	Custom	No
risk_error_handling	Error cases are handled gracefully	Custom	No
risk_data_integrity	No data loss or corruption risks	Custom	Yes

Raw Definition

57 lines

name: multi-faceted-review
description: Multi-dimensional review gate — scope, standards, and risk
# Note: {protocol_id} is resolved at gate-review time from the active checkpoint

checks:
  # Scope Validation — does the implementation match requirements?
  - id: scope_prd_match
    description: PRD exists (scope validation is performed by code-reviewer agent)
    check: file:.sniper/artifacts/{protocol_id}/prd.md
    blocking: true

  - id: scope_acceptance_criteria
    description: All acceptance criteria from stories are addressed
    check: "grep:.sniper/artifacts/{protocol_id}/stories/:shall"
    blocking: true

  - id: scope_no_creep
    description: No undocumented features added beyond spec
    check: file:.sniper/artifacts/{protocol_id}/review-report.md
    blocking: false

  # Standards Enforcement — does the code follow conventions?
  - id: standards_conventions
    description: Code follows project conventions
    check: file:.sniper/conventions.yaml
    blocking: false

  - id: standards_test_coverage
    description: Tests exist for new functionality
    command: "find . -name '*.test.*' -o -name '*.spec.*' | grep -q ."
    blocking: true

  - id: standards_lint_clean
    description: No lint errors in changed files
    command: "${lint_command}"
    blocking: true

  # Risk Scoring — are there security, performance, or reliability risks?
  - id: risk_security
    description: No OWASP Top 10 vulnerabilities detected
    check: 'grep:.sniper/artifacts/{protocol_id}/review-report.md:"## Security"'
    blocking: true

  - id: risk_performance
    description: No obvious performance regressions
    check: 'grep:.sniper/artifacts/{protocol_id}/review-report.md:"## Performance"'
    blocking: false

  - id: risk_error_handling
    description: Error cases are handled gracefully
    check: 'grep:.sniper/artifacts/{protocol_id}/review-report.md:"## Error Handling"'
    blocking: false

  - id: risk_data_integrity
    description: No data loss or corruption risks
    check: 'grep:.sniper/artifacts/{protocol_id}/review-report.md:"## Data Integrity"'
    blocking: true